Check node type above custom update fn #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yeah, let’s do this! thanks! |
andrewlu0
pushed a commit
to trybaseplate/tiptap
that referenced
this pull request
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty simple one - I was running into a bunch of issues with the wrong NodeView component rendering for a node after I dragged it. After reading this issue on the ProseMirror forums https://discuss.prosemirror.net/t/nodeview-dragging-results-in-duplicates-bug/3962/2 I realized the culprit was my custom
updatefunction, which wasn't checking for node type.I couldn't think of any reason why somebody would want a different node type's component to render, so I think it would help people avoid this bug to move the node type check above the custom update function running. Let me know what you think.